| To: | Tao Ma <tao.ma@xxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH v2] XFS: Let the broken fiemap work in query mode. |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Wed, 28 Apr 2010 07:33:59 -0400 |
| Cc: | linux-kernel@xxxxxxxxxxxxxxx, Eric Sandeen <sandeen@xxxxxxxxxx>, xfs@xxxxxxxxxxx, Alex Elder <aelder@xxxxxxx>, Christoph Hellwig <hch@xxxxxx> |
| In-reply-to: | <1272423625-20142-1-git-send-email-tao.ma@xxxxxxxxxx> |
| References: | <20100428023058.GD9783@dastard> <1272423625-20142-1-git-send-email-tao.ma@xxxxxxxxxx> |
| User-agent: | Mutt/1.5.19 (2009-01-05) |
On Wed, Apr 28, 2010 at 11:00:25AM +0800, Tao Ma wrote: > - bm.bmv_count = fieinfo->fi_extents_max + 1; > + bm.bmv_count = !fieinfo->fi_extents_max ? MAXEXTNUM : > + fieinfo->fi_extents_max + 1; > + bm.bmv_count = MIN(bm.bmv_count, > + (__s32)(PAGE_SIZE * 16 / sizeof(struct getbmapx))); I would use min_t here instead of the case, but otherwise the patch looks good to me, Reviewed-by: Christoph Hellwig <hch@xxxxxx> |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH] xfs: add a shrinker to background inode reclaim, Christoph Hellwig |
|---|---|
| Next by Date: | [PATCH 00/11] remove xfs_iomap, Christoph Hellwig |
| Previous by Thread: | [PATCH v2] XFS: Let the broken fiemap work in query mode., Tao Ma |
| Next by Thread: | [PATCH v3] XFS: Let the broken fiemap work in query mode., Tao Ma |
| Indexes: | [Date] [Thread] [Top] [All Lists] |