xfs
[Top] [All Lists]

Re: [PATCH] xfs: Improve scalability of busy extent tracking

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH] xfs: Improve scalability of busy extent tracking
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Fri, 23 Apr 2010 13:25:33 +1000
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20100422171035.GA29007@xxxxxxxxxxxxx>
References: <1271828835-2094-1-git-send-email-david@xxxxxxxxxxxxx> <20100422110758.GA22295@xxxxxxxxxxxxx> <20100422171035.GA29007@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.20 (2009-06-14)
On Thu, Apr 22, 2010 at 01:10:35PM -0400, Christoph Hellwig wrote:
> On Thu, Apr 22, 2010 at 07:07:58AM -0400, Christoph Hellwig wrote:
> > Oh, and while I'm at it:
> > 
> > I'd move the list_del_init(&busyp->list); from xfs_trans_free_busy into
> > xfs_alloc_clear_busy, we also do the list insertation inside
> > xfs_alloc_busy_insert, so that makes it symmetic.
> 
> Or just merge the loop calling xfs_alloc_clear_busy directly in
> xfs_trans_free, ala:

Yeah, that looks like a sane thing to do. I'll update it this way.

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>