Re: [PATCH 1/2] mm: add context argument to shrinker callback

xfs

Re: [PATCH 1/2] mm: add context argument to shrinker callback

To:	Nick Piggin <npiggin@xxxxxxx>
Subject:	Re: [PATCH 1/2] mm: add context argument to shrinker callback
From:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date:	Thu, 22 Apr 2010 12:42:47 -0400
Cc:	Christoph Hellwig <hch@xxxxxxxxxxxxx>, Dave Chinner <david@xxxxxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx, linux-mm@xxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
In-reply-to:	<20100422163801.GZ5683@laptop>
References:	<1271118255-21070-1-git-send-email-david@xxxxxxxxxxxxx> <1271118255-21070-2-git-send-email-david@xxxxxxxxxxxxx> <20100418001514.GA26575@xxxxxxxxxxxxx> <20100419140039.GQ5683@laptop> <20100420004149.GA14744@dastard> <20100420083840.GR5683@laptop> <20100420103216.GK15130@dastard> <20100421084004.GS5683@laptop> <20100422163211.GA2478@xxxxxxxxxxxxx> <20100422163801.GZ5683@laptop>
User-agent:	Mutt/1.5.19 (2009-01-05)

On Fri, Apr 23, 2010 at 02:38:01AM +1000, Nick Piggin wrote:
> I don't understand, it should be implemented like just all the other
> shrinkers AFAIKS. Like the dcache one that has to shrink multiple
> superblocks. There is absolutely no requirement for this API change
> to implement it in XFS.

The dcache shrinker is an example for a complete mess.

> But the shrinker list *is* a global list. The downside of it in the way
> it was done in the XFS patch is that 1) it is much larger than a simple
> list head, and 2) not usable by anything other then the shrinker.

It is an existing global list just made more useful.  Whenever a driver
has muliple instances of pool that need shrinking this comes in useful,
it's not related to filesystems at all.

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH 1/2] mm: add context argument to shrinker callback, (continued) [PATCH 1/2] mm: add context argument to shrinker callback, Dave Chinner Re: [PATCH 1/2] mm: add context argument to shrinker callback, KOSAKI Motohiro Re: [PATCH 1/2] mm: add context argument to shrinker callback, Christoph Hellwig Re: [PATCH 1/2] mm: add context argument to shrinker callback, Nick Piggin Re: [PATCH 1/2] mm: add context argument to shrinker callback, Dave Chinner Re: [PATCH 1/2] mm: add context argument to shrinker callback, Nick Piggin Re: [PATCH 1/2] mm: add context argument to shrinker callback, Dave Chinner Re: [PATCH 1/2] mm: add context argument to shrinker callback, Nick Piggin Re: [PATCH 1/2] mm: add context argument to shrinker callback, Christoph Hellwig Re: [PATCH 1/2] mm: add context argument to shrinker callback, Nick Piggin Re: [PATCH 1/2] mm: add context argument to shrinker callback, Christoph Hellwig <= Re: [PATCH 1/2] mm: add context argument to shrinker callback, Nick Piggin Re: [PATCH 1/2] mm: add context argument to shrinker callback, Dave Chinner Re: [PATCH 1/2] mm: add context argument to shrinker callback, Dave Chinner Re: [PATCH 1/2] mm: add context argument to shrinker callback, Avi Kivity Re: [PATCH 1/2] mm: add context argument to shrinker callback, Dave Chinner

Previous by Date:	Re: [PATCH 1/2] mm: add context argument to shrinker callback, Nick Piggin
Next by Date:	Re: different error messages for mkfs.xfs -ssize, Christoph Hellwig
Previous by Thread:	Re: [PATCH 1/2] mm: add context argument to shrinker callback, Nick Piggin
Next by Thread:	Re: [PATCH 1/2] mm: add context argument to shrinker callback, Nick Piggin
Indexes:	[Date] [Thread] [Top] [All Lists]