xfs
[Top] [All Lists]

Re: [PATCHv2 4/5] xfs: record log sector size rather than log2(that)

To: Alex Elder <aelder@xxxxxxx>
Subject: Re: [PATCHv2 4/5] xfs: record log sector size rather than log2(that)
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Sun, 18 Apr 2010 13:18:05 -0400
Cc: xfs@xxxxxxxxxxx
In-reply-to: <201004162053.o3GKrrgr025189@xxxxxxxxxxxxxxxxxxxxxx>
References: <201004162053.o3GKrrgr025189@xxxxxxxxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.19 (2009-01-05)
On Fri, Apr 16, 2010 at 03:53:53PM -0500, Alex Elder wrote:
> Change struct log so it keeps track of the size (in basic blocks) of
> a log sector in l_sectBBsize rather than the log-base-2 of that
> value (previously, l_sectbb_log).  The name was chosen for
> consistency with the other fields in the structure that represent
> a number of basic blocks.
> 
> (Updated so that a variable used in computing and verifying a log's
> sector size is named "log2_size".  Also added the "BB" to the
> structure field name, based on feedback from Eric Sandeen.  Also
> dropped some superfluous parentheses.)

Looks good.  Eventually we should replace all the "BB" with "bb" in
the log code, but for now this is a good enough.

<Prev in Thread] Current Thread [Next in Thread>