Re: [PATCH 4/5] xfs: record log sector size rather than log2(that)

[Christoph Hellwig <hch@xxxxxxxxxxxxx>]

On Thu, Apr 15, 2010 at 01:17:37PM -0500, Alex Elder wrote:
> Change struct log so it keeps track of the size (in basic blocks)
> of a log sector in l_sectsize rather than the log-base-2 of that
> value (previously, l_sectbb_log).  Rename a variable holding the
> sector size to more closely match the field it comes from.
> 
> (Updated so that a variable used in computing and verifying a log's
> sector size is named simply "size".  Also dropped some superfluous
> parentheses and renamed another local variable.)
> 
> Signed-off-by: Alex Elder <aelder@xxxxxxx>

Looks correct, but I don't think the choice of "size" for a log2
is particularly intuitive.