xfs
[Top] [All Lists]

Re: [PATCH 4/5] xfs: record log sector size rather than log2(that)

To: Alex Elder <aelder@xxxxxxx>
Subject: Re: [PATCH 4/5] xfs: record log sector size rather than log2(that)
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Fri, 16 Apr 2010 13:10:59 -0400
Cc: XFS Mailing List <xfs@xxxxxxxxxxx>
In-reply-to: <1271355457.2680.93.camel@doink>
References: <1271355457.2680.93.camel@doink>
User-agent: Mutt/1.5.19 (2009-01-05)
On Thu, Apr 15, 2010 at 01:17:37PM -0500, Alex Elder wrote:
> Change struct log so it keeps track of the size (in basic blocks)
> of a log sector in l_sectsize rather than the log-base-2 of that
> value (previously, l_sectbb_log).  Rename a variable holding the
> sector size to more closely match the field it comes from.
> 
> (Updated so that a variable used in computing and verifying a log's
> sector size is named simply "size".  Also dropped some superfluous
> parentheses and renamed another local variable.)
> 
> Signed-off-by: Alex Elder <aelder@xxxxxxx>

Looks correct, but I don't think the choice of "size" for a log2
is particularly intuitive.

<Prev in Thread] Current Thread [Next in Thread>