xfs
[Top] [All Lists]

Re: [PATCH 3/5] xfs: minor odds and ends in xfs_log_recover.c

To: Alex Elder <aelder@xxxxxxx>
Subject: Re: [PATCH 3/5] xfs: minor odds and ends in xfs_log_recover.c
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Fri, 16 Apr 2010 13:09:00 -0400
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1271355454.2680.92.camel@doink>
References: <1271355454.2680.92.camel@doink>
User-agent: Mutt/1.5.19 (2009-01-05)
On Thu, Apr 15, 2010 at 01:17:34PM -0500, Alex Elder wrote:
> Odds and ends in "xfs_log_recover.c".  This patch just contains some
> minor things that didn't seem to warrant their own individual
> patches:
> - In xlog_bread_noalign(), drop an assertion that a pointer is
>   non-null (the crash will tell us it was a bad pointer).
> - Add a more descriptive header comment for xlog_find_verify_cycle().
> - Make a few additions to the comments in xlog_find_head().  Also
>   rearrange some expressions in a few spots to produce the same
>   result, but in a way that seems more clear what's being computed.
> 
> (Updated in response to Dave's review comments.  Note I did not
> split this patch like I said I would.)
> 
> Signed-off-by: Alex Elder <aelder@xxxxxxx>

Looks good,


Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>