xfs
[Top] [All Lists]

Re: xfstests: honor comments in the test group file

To: xfs@xxxxxxxxxxx
Subject: Re: xfstests: honor comments in the test group file
From: Alex Elder <aelder@xxxxxxx>
Date: Fri, 16 Apr 2010 12:07:17 -0500
In-reply-to: <1267208947.2756.11.camel@doink>
References: <1267208947.2756.11.camel@doink>
Reply-to: aelder@xxxxxxx
Will someone review this for me?        -Alex

On Fri, 2010-02-26 at 12:29 -0600, Alex Elder wrote:
> There are some spots in the "group" file where test numbers have
> groups listed after a '#' character, clearly intending for those
> groups to be commented out.  But the way the group list gets
> generated that commenting doesn't work, and in fact these tests
> explicitly *are* included in such commented-out groups.
> 
> This patch fixes that, stripping out all comments (which start with
> a '#' character and end with a newline) from the file before
> building the set of test numbers for a group.
> 
> Signed-off-by: Alex Elder <aelder@xxxxxxx>
> 
> ---
>  common |    7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> Index: b/common
> ===================================================================
> --- a/common
> +++ b/common
> @@ -58,9 +58,10 @@ do
>      if $group
>      then
>         # arg after -g
> -       group_list=`sed -n <group -e 's/$/ /' -e "/^[0-9][0-9][0-9].*
> $r /"'{
> -s/ .*//p
> -}'`
> +       group_list=$(sed -n < group \
> +                       -e 's/#.*//' \
> +                       -e 's/$/ /' \
> +                       -e "/^[0-9][0-9][0-9].* $r /"'{ s/ .*//p }')
>         if [ -z "$group_list" ]
>         then
>             echo "Group \"$r\" is empty or not defined?"
> 
> 
> _______________________________________________
> xfs mailing list
> xfs@xxxxxxxxxxx
> http://oss.sgi.com/mailman/listinfo/xfs



<Prev in Thread] Current Thread [Next in Thread>
  • Re: xfstests: honor comments in the test group file, Alex Elder <=