| To: | Alex Elder <aelder@xxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 2/5] xfs: avoid repeated pointer dereferences |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Fri, 16 Apr 2010 13:06:24 -0400 |
| Cc: | xfs@xxxxxxxxxxx |
| In-reply-to: | <1271355450.2680.91.camel@doink> |
| References: | <1271355450.2680.91.camel@doink> |
| User-agent: | Mutt/1.5.19 (2009-01-05) |
On Thu, Apr 15, 2010 at 01:17:30PM -0500, Alex Elder wrote: > In xlog_find_cycle_start() use a local variable for some repeated > operations rather than constantly accessing the memory location > whose address is passed in. > > (This version drops an assertion that a pointer is non-null.) > > Signed-off-by: Alex Elder <aelder@xxxxxxx> I'm not entirely convinced about the need for this, but it at least looks correct, so: Reviewed-by: Christoph Hellwig <hch@xxxxxx> |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH 1/5] xfs: change a few labels in xfs_log_recover.c, Christoph Hellwig |
|---|---|
| Next by Date: | Re: xfstests: honor comments in the test group file, Alex Elder |
| Previous by Thread: | [PATCH 2/5] xfs: avoid repeated pointer dereferences, Alex Elder |
| Next by Thread: | [PATCH 3/5] xfs: minor odds and ends in xfs_log_recover.c, Alex Elder |
| Indexes: | [Date] [Thread] [Top] [All Lists] |