xfs
[Top] [All Lists]

Re: [PATCH 3/8] xfs: make the log ticket transaction id random

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 3/8] xfs: make the log ticket transaction id random
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Tue, 13 Apr 2010 14:12:25 -0400
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <20100405233910.GA11036@dastard>
References: <1270125691-29266-1-git-send-email-david@xxxxxxxxxxxxx> <1270125691-29266-4-git-send-email-david@xxxxxxxxxxxxx> <20100403093156.GD20166@xxxxxxxxxxxxx> <20100405233910.GA11036@dastard>
User-agent: Mutt/1.5.19 (2009-01-05)
On Tue, Apr 06, 2010 at 09:39:10AM +1000, Dave Chinner wrote:
> Ideally, yes. However, I didn't want to introduce a global
> monatomically increasing counter into the transaction code. I'm
> seeing upwards of 50-60k transactions/s on my test box - that's
> getting into the range where reliable global counters become
> scalability limitations. I know this can be solved, but it is
> somewhat complex and I'm not sure at this point that the complexity
> is necessary. What do you think?

I think making log revoery absolutely fail proof is nessecary, but for
now your version defintively is an improvment over the current version,
so ACK.

<Prev in Thread] Current Thread [Next in Thread>