On Fri, Apr 09, 2010 at 05:31:06PM -0500, Alex Elder wrote:
> Minor things that didn't seem to warrant their own individual
> - In xlog_bread_noalign(), reorder assertions so the buffer pointer
> is known to be non-null before attempting to dereference it.
That's OK, but if you are debugging then it'll be obvious what
happend by it being a null ptr dereference rather than an assert
failure. Hence if anything I'd just kill the ASSERT(bp)....
> - Add a more descriptive header comment for xlog_find_verify_cycle().
It just describes what the code does - I don't think it make the
code any clearer and makes it more likely that if we ever change the
code the comment will then be wrong...
> - Make a few additions to the comments in xlog_find_head(). Also
> rearrange some expressions in a few spots to produce the same
> result, but in a way that seems more clear what's being computed.
I'd say this is probably the only bits of the patch that add value.
Can you split this one out by itself?