xfs
[Top] [All Lists]

Re: [PATCHv2 5/10] xfs: encapsulate bbcount validity checking

To: Alex Elder <aelder@xxxxxxx>
Subject: Re: [PATCHv2 5/10] xfs: encapsulate bbcount validity checking
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Mon, 12 Apr 2010 16:35:14 +1000
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1270852091.7840.143.camel@doink>
References: <1270852091.7840.143.camel@doink>
User-agent: Mutt/1.5.20 (2009-06-14)
On Fri, Apr 09, 2010 at 05:28:11PM -0500, Alex Elder wrote:
> Define a function that encapsulates checking the validity of a log
> block count.
> 
> (Updated from previous version--no longer includes error reporting in the
> encapsulated validation function.)
> 
> Signed-off-by: Alex Elder <aelder@xxxxxxx>

Reviewed-by: Dave Chinner <david@xxxxxxxxxxxxx>

but one small change needed:

>  
> +/*
> + * Verify the given count of basic blocks is valid number of blocks
> + * to specify for an operation involving the given XFS log buffer.
> + * Returns nonzero if the count is valid, 0 otherwise.
> + */
> +
> +inline static int

static inline int

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>