xfs
[Top] [All Lists]

Re: [PATCH 4/8] xfs: add log item recovery tracing

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 4/8] xfs: add log item recovery tracing
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Tue, 6 Apr 2010 09:40:16 +1000
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20100403093638.GE20166@xxxxxxxxxxxxx>
References: <1270125691-29266-1-git-send-email-david@xxxxxxxxxxxxx> <1270125691-29266-5-git-send-email-david@xxxxxxxxxxxxx> <20100403093638.GE20166@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.20 (2009-06-14)
On Sat, Apr 03, 2010 at 05:36:38AM -0400, Christoph Hellwig wrote:
> On Thu, Apr 01, 2010 at 11:41:27PM +1100, Dave Chinner wrote:
> > From: Dave Chinner <dchinner@xxxxxxxxxx>
> > 
> > Currently there is no tracing in log recovery, so it is difficult to
> > determine what is going on when something goes wrong.
> > 
> > Add tracing for log item recovery to provide visibility into the log
> > recovery process. The tracing added shows regions being extracted
> > from the log transactions and added to the transaction hash forming
> > recovery items, followed by the reordering, cancelling and finally
> > recovery of the items.
> > 
> > Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>
> > ---
> >  fs/xfs/linux-2.6/xfs_trace.c |    3 +
> >  fs/xfs/linux-2.6/xfs_trace.h |  147 
> > ++++++++++++++++++++++++++++++++++++++++++
> >  fs/xfs/xfs_buf_item.h        |    2 +-
> >  fs/xfs/xfs_log_recover.c     |   44 ++++++++++--
> >  4 files changed, 187 insertions(+), 9 deletions(-)
> > 
> 
> > +#define XFS_LOG_ITEM_TYPE \
> > +   { 0x1236,       "XFS_LI_EFI" }, \
> > +   { 0x1237,       "XFS_LI_EFD" }, \
> > +   { 0x1238,       "XFS_LI_IUNLINK" }, \
> > +   { 0x123b,       "XFS_LI_INODE" }, \
> > +   { 0x123c,       "XFS_LI_BUF" }, \
> > +   { 0x123d,       "XFS_LI_DQUOT" }, \
> > +   { 0x123e,       "XFS_LI_QUOTAOFF" }
> 
> For the other trace events I kept these close to the defintion
> of these flags. 

np, I'll move it.

> Is there a good reason you use the numerical
> and not hte symbolic names on the left side?

Brain fart. I'll fix it up.

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>