xfs
[Top] [All Lists]

Re: [PATCH] xfstests: exit non-0 if fs check fails

To: Eric Sandeen <sandeen@xxxxxxxxxx>
Subject: Re: [PATCH] xfstests: exit non-0 if fs check fails
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Thu, 1 Apr 2010 11:19:56 +1100
Cc: xfs-oss <xfs@xxxxxxxxxxx>
In-reply-to: <4BB3DCEF.8040704@xxxxxxxxxx>
References: <4BB3DCEF.8040704@xxxxxxxxxx>
User-agent: Mutt/1.5.20 (2009-06-14)
On Wed, Mar 31, 2010 at 06:38:23PM -0500, Eric Sandeen wrote:
> Right now if any of the _check_scratch_fs tests etc fail,
> the check script exits but with 0 status.
> 
> This change will cause the status to be non-0 so we can detect
> the error.
> 
> Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>

Wouldn't it be better to do:

-   [ $ok -eq 0 ] && exit 1
+    if [ $ok -eq 0 ]; then
+       status=1
+       exit 1
+    fi

To catch all failures rather than just the fsck failure?

> ---
> 
> (aside - we could make it 2 instead of 1, so that a calling script
> could fsck and continue ... thoughts?)

I think if a test corrupts a filesystem, the test run should stop
so the failure can be analysed without needing to reproduce it
again...

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>