[Top] [All Lists]

Re: [PATCH, RFC] xfstests: random fallocate calls in fsx

To: Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject: Re: [PATCH, RFC] xfstests: random fallocate calls in fsx
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Wed, 31 Mar 2010 16:41:56 +1100
Cc: xfs mailing list <xfs@xxxxxxxxxxx>
In-reply-to: <4BB2D65D.5000402@xxxxxxxxxxx>
References: <4A0B420E.3070908@xxxxxxxxxxx> <4BB2D65D.5000402@xxxxxxxxxxx>
User-agent: Mutt/1.5.20 (2009-06-14)
On Tue, Mar 30, 2010 at 11:58:05PM -0500, Eric Sandeen wrote:
> Eric Sandeen wrote:
> > Seems to work for me.  Any comments/suggestions?
> > 
> > I can probably make it fall back to the xfs ioctl if fallocate
> > isn't supported, if strongly desired.
> Anybody feel like reviewing this?  Seems like having fallocate in the mix
> would be good.

Looks like all of the autoconf magic went in with the fiemap-tester
changes, so a rebase is definitely needed... :/

Otherwise the changes seem sane - I can't find anything obviously
wrong reading over them. I say clean it up, check it doesn't
obviously break and check it in...


Dave Chinner

<Prev in Thread] Current Thread [Next in Thread>