Re: [PATCH 4/7] xfs: kill XLOG_SECTOR_ROUND*()

[Christoph Hellwig <hch@xxxxxxxxxxxxx>]

> @@ -82,8 +77,8 @@ xlog_get_bp(
>  
>       if (log->l_sectbb_log) {
>               if (nbblks > 1)
> -                     nbblks += XLOG_SECTOR_ROUNDUP_BBCOUNT(log, 1);
> -             nbblks = XLOG_SECTOR_ROUNDUP_BBCOUNT(log, nbblks);
> +                     nbblks += xlog_sectbb(log);
> +             nbblks = round_up(nbblks, xlog_sectbb(log));

This arithmetics would benefit greatly from a comment why we're
adding one log block to it and then round it up.

Anyway, patch looks good,


Reviewed-by: Christoph Hellwig <hch@xxxxxx>