[Top] [All Lists]

Re: [PATCH 0/4] xfs_log_write cleanups and vector support

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 0/4] xfs_log_write cleanups and vector support
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Tue, 16 Mar 2010 12:53:59 +1100
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20100315155151.642965370@xxxxxxxxxxxxxxxxxxxxxx>
References: <20100315155151.642965370@xxxxxxxxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.20 (2009-06-14)
On Mon, Mar 15, 2010 at 11:51:51AM -0400, Christoph Hellwig wrote:
> As mention during the review of the first posting of the transaction
> subsystem cleanup series I really didn't like the concept of mixing
> the xfs_log_write cleanup with adding the new vector functionality.
> Here's a patch series to reshuffle this work into a series that I
> feel able to follow and throw in some minimal additional cleanups.
> First patch is the factoring out of helpers from xlog_write without
> functionality change, second is a re-indent of xlog_write including
> moving variable declaration to inner blocks, again without functionality
> change, third is the introduction of the log vectors, including the
> relatively small changes in xlog_write, and fourth is a small incremental
> cleanup patch.

I've had a quick look over this and it seems ok. I'll test and
review them more closely, and if they are OK I'll add them to the
trans-cleanup branch...

Thanks for doing this, Christoph.


Dave Chinner

<Prev in Thread] Current Thread [Next in Thread>