Re: [PATCH 8/9] xfs: Clean up xfs_trans_committed code after factoring

xfs

Re: [PATCH 8/9] xfs: Clean up xfs_trans_committed code after factoring

To:	Dave Chinner <david@xxxxxxxxxxxxx>
Subject:	Re: [PATCH 8/9] xfs: Clean up xfs_trans_committed code after factoring
From:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date:	Mon, 15 Mar 2010 11:20:31 -0400
Cc:	xfs@xxxxxxxxxxx
In-reply-to:	<1268620506-10799-9-git-send-email-david@xxxxxxxxxxxxx>
References:	<1268620506-10799-1-git-send-email-david@xxxxxxxxxxxxx> <1268620506-10799-9-git-send-email-david@xxxxxxxxxxxxx>
User-agent:	Mutt/1.5.19 (2009-01-05)

On Mon, Mar 15, 2010 at 01:35:05PM +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> Now that the code has been factored, clean up all the remaining
> style cruft, simplify the code and re-order functions so that it
> doesn't need forward declarations.
> 
> Also move the remaining functions that require forward declarations
> (xfs_trans_uncommit, xfs_trans_free) so that all the forward
> declarations can be removed from the file.

Looks good,


Reviewed-by: Christoph Hellwig <hch@xxxxxx>

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH 3/9] xfs: remove stale parameter from ->iop_unpin method, (continued) [PATCH 3/9] xfs: remove stale parameter from ->iop_unpin method, Dave Chinner [PATCH 1/9] xfs: factor log item initialisation, Dave Chinner [PATCH 9/9] xfs: log ticket reservation underestimates the number of iclogs, Dave Chinner Re: [PATCH 9/9] xfs: log ticket reservation underestimates the number of iclogs, Christoph Hellwig Re: [PATCH 9/9] xfs: log ticket reservation underestimates the number of iclogs, Christoph Hellwig Re: [PATCH 9/9] xfs: log ticket reservation underestimates the number of iclogs, Dave Chinner [PATCH 7/9] xfs: update and factor xfs_trans_committed(), Dave Chinner [PATCH 4/9] xfs: fix reservation release commit flag in xfs_bmap_add_attrfork(), Dave Chinner [PATCH 6/9] xfs: clean up xfs_trans_commit logic even more, Dave Chinner [PATCH 8/9] xfs: Clean up xfs_trans_committed code after factoring, Dave Chinner Re: [PATCH 8/9] xfs: Clean up xfs_trans_committed code after factoring, Christoph Hellwig <= [PATCH 5/9] xfs: split out iclog writing from xfs_trans_commit(), Dave Chinner

Previous by Date:	Re: [PATCH] xfs: don't warn about page discards on shutdown, Christoph Hellwig
Next by Date:	Re: 2.6.33 crash: invalid opcode: 0000 [#1] SMP: EIP: [<c11a018b>] assfail+0x1b/0x20 SS:ESP 0068:f687bf14, Justin Piszcz
Previous by Thread:	[PATCH 8/9] xfs: Clean up xfs_trans_committed code after factoring, Dave Chinner
Next by Thread:	[PATCH 5/9] xfs: split out iclog writing from xfs_trans_commit(), Dave Chinner
Indexes:	[Date] [Thread] [Top] [All Lists]