xfs
[Top] [All Lists]

Re: [PATCH 8/9] xfs: Clean up xfs_trans_committed code after factoring

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 8/9] xfs: Clean up xfs_trans_committed code after factoring
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Mon, 15 Mar 2010 11:20:31 -0400
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1268620506-10799-9-git-send-email-david@xxxxxxxxxxxxx>
References: <1268620506-10799-1-git-send-email-david@xxxxxxxxxxxxx> <1268620506-10799-9-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.19 (2009-01-05)
On Mon, Mar 15, 2010 at 01:35:05PM +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> Now that the code has been factored, clean up all the remaining
> style cruft, simplify the code and re-order functions so that it
> doesn't need forward declarations.
> 
> Also move the remaining functions that require forward declarations
> (xfs_trans_uncommit, xfs_trans_free) so that all the forward
> declarations can be removed from the file.

Looks good,


Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>