xfs
[Top] [All Lists]

Re: [PATCH] xfstests: fix log filtering in 223's testcase

To: Dmitry Monakhov <dmonakhov@xxxxxxxxxx>
Subject: Re: [PATCH] xfstests: fix log filtering in 223's testcase
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Tue, 09 Mar 2010 11:58:22 -0600
Cc: xfs-oss <xfs@xxxxxxxxxxx>, Christoph Hellwig <hch@xxxxxxxxxxxxx>, Eric Sandeen <sandeen@xxxxxxxxxx>
In-reply-to: <876355pfrh.fsf@xxxxxxxxxx>
References: <876355pfrh.fsf@xxxxxxxxxx>
User-agent: Thunderbird 2.0.0.21 (X11/20090320)
Dmitry Monakhov wrote:
> Msg filter was missed in one place, so test failed if
> $SCRATCH_MNT is different than /mnt/scratch.diff 
> 
> Signed-off-by: Dimitry Monakhov <dmonakhov@xxxxxxxxxx>

Reviewed-by: Eric Sandeen <sandeen@xxxxxxxxxxx>

Whoops, yep!  Sorry.

I'll commit this shortly.

Thanks,
-Eric

> ---
>  223     |    3 ++-
>  223.out |   10 +++++-----
>  2 files changed, 7 insertions(+), 6 deletions(-)
> 
> diff --git a/223 b/223
> index 5c95f7d..7af026c 100755
> --- a/223
> +++ b/223
> @@ -86,7 +86,8 @@ for SUNIT_K in 8 16 32 64 128; do
>  
>       echo "=== Testing size 1g falloc on ${SUNIT_K}k stripe ==="
>       xfs_io -F -f -c "falloc 0 1g" $SCRATCH_MNT/file-1g-falloc &>> $seq.full
> -     src/t_stripealign $SCRATCH_MNT/file-1g-falloc $SUNIT_BLOCKS
> +     src/t_stripealign $SCRATCH_MNT/file-1g-falloc $SUNIT_BLOCKS \
> +         | _filter_scratch
>  
>       rm -f $SCRATCH_MNT/file-1g-falloc | _filter_scratch
>  
> diff --git a/223.out b/223.out
> index c9588ef..2fb3122 100644
> --- a/223.out
> +++ b/223.out
> @@ -46,7 +46,7 @@ SCRATCH_MNT/file-3-2097152-write: well-aligned
>  SCRATCH_MNT/file-4-2097152-falloc: well-aligned
>  SCRATCH_MNT/file-4-2097152-write: well-aligned
>  === Testing size 1g falloc on 8k stripe ===
> -/mnt/scratch/file-1g-falloc: well-aligned
> +SCRATCH_MNT/file-1g-falloc: well-aligned
>  === Testing size 1073745920 falloc on 8k stripe ===
>  SCRATCH_MNT/file-1073745920-falloc: well-aligned
>  === mkfs with su 4 blocks x 4 ===
> @@ -96,7 +96,7 @@ SCRATCH_MNT/file-3-4194304-write: well-aligned
>  SCRATCH_MNT/file-4-4194304-falloc: well-aligned
>  SCRATCH_MNT/file-4-4194304-write: well-aligned
>  === Testing size 1g falloc on 16k stripe ===
> -/mnt/scratch/file-1g-falloc: well-aligned
> +SCRATCH_MNT/file-1g-falloc: well-aligned
>  === Testing size 1073745920 falloc on 16k stripe ===
>  SCRATCH_MNT/file-1073745920-falloc: well-aligned
>  === mkfs with su 8 blocks x 4 ===
> @@ -146,7 +146,7 @@ SCRATCH_MNT/file-3-8388608-write: well-aligned
>  SCRATCH_MNT/file-4-8388608-falloc: well-aligned
>  SCRATCH_MNT/file-4-8388608-write: well-aligned
>  === Testing size 1g falloc on 32k stripe ===
> -/mnt/scratch/file-1g-falloc: well-aligned
> +SCRATCH_MNT/file-1g-falloc: well-aligned
>  === Testing size 1073745920 falloc on 32k stripe ===
>  SCRATCH_MNT/file-1073745920-falloc: well-aligned
>  === mkfs with su 16 blocks x 4 ===
> @@ -196,7 +196,7 @@ SCRATCH_MNT/file-3-16777216-write: well-aligned
>  SCRATCH_MNT/file-4-16777216-falloc: well-aligned
>  SCRATCH_MNT/file-4-16777216-write: well-aligned
>  === Testing size 1g falloc on 64k stripe ===
> -/mnt/scratch/file-1g-falloc: well-aligned
> +SCRATCH_MNT/file-1g-falloc: well-aligned
>  === Testing size 1073745920 falloc on 64k stripe ===
>  SCRATCH_MNT/file-1073745920-falloc: well-aligned
>  === mkfs with su 32 blocks x 4 ===
> @@ -246,6 +246,6 @@ SCRATCH_MNT/file-3-33554432-write: well-aligned
>  SCRATCH_MNT/file-4-33554432-falloc: well-aligned
>  SCRATCH_MNT/file-4-33554432-write: well-aligned
>  === Testing size 1g falloc on 128k stripe ===
> -/mnt/scratch/file-1g-falloc: well-aligned
> +SCRATCH_MNT/file-1g-falloc: well-aligned
>  === Testing size 1073745920 falloc on 128k stripe ===
>  SCRATCH_MNT/file-1073745920-falloc: well-aligned

<Prev in Thread] Current Thread [Next in Thread>