xfs
[Top] [All Lists]

Re: xfs: add fs name to kthreads

To: Jan Engelhardt <jengelh@xxxxxxxxxx>
Subject: Re: xfs: add fs name to kthreads
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Mon, 8 Mar 2010 12:28:24 +1100
Cc: xfs@xxxxxxxxxxx
In-reply-to: <alpine.LSU.2.01.1003062033100.16438@xxxxxxxxxxxxxxx>
References: <alpine.LSU.2.01.1003062033100.16438@xxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.18 (2008-05-17)
On Sat, Mar 06, 2010 at 08:34:39PM +0100, Jan Engelhardt wrote:
> Signed-off-by: Jan Engelhardt <jengelh@xxxxxxxxxx>

Looks ok, but a couple of things. First, it would be good if you
supplied a reason/justification for the patch so the commit message
will tell us why this change was made.

> Index: linux-2.6.33/fs/xfs/linux-2.6/xfs_buf.c
> ===================================================================
> --- linux-2.6.33.orig/fs/xfs/linux-2.6/xfs_buf.c
> +++ linux-2.6.33/fs/xfs/linux-2.6/xfs_buf.c
> @@ -1527,7 +1527,8 @@ xfs_mapping_buftarg(
>  
>  STATIC int
>  xfs_alloc_delwrite_queue(
> -     xfs_buftarg_t           *btp)
> +     xfs_buftarg_t           *btp,
> +     const char *fsname)

Please keep the same indent style as the rest of the functions. i.e

        const char              *fsname)

> @@ -1548,7 +1549,8 @@ out_error:
>  xfs_buftarg_t *
>  xfs_alloc_buftarg(
>       struct block_device     *bdev,
> -     int                     external)
> +     int                     external,
> +     const char *fsname)

Same again.

> @@ -899,10 +899,11 @@ xfsaild(
>  
>  int
>  xfsaild_start(
> -     struct xfs_ail  *ailp)
> +     struct xfs_ail  *ailp,
> +     const char *fsname)
>  {
>       ailp->xa_target = 0;
> -     ailp->xa_task = kthread_run(xfsaild, ailp, "xfsaild");
> +     ailp->xa_task = kthread_run(xfsaild, ailp, "xfsaild/%s", fsname);

No need to pass the name into this function. It can be retrieved
from ailp->xa_mount->m_fsname.

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>