xfs
[Top] [All Lists]

Re: [PATCH 9/9] xfs: factor xlog_write and make use of new log vector st

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 9/9] xfs: factor xlog_write and make use of new log vector structure
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Sat, 6 Mar 2010 10:48:36 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1267840284-4652-10-git-send-email-david@xxxxxxxxxxxxx>
References: <1267840284-4652-1-git-send-email-david@xxxxxxxxxxxxx> <1267840284-4652-10-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.19 (2009-01-05)
On Sat, Mar 06, 2010 at 12:51:24PM +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> xlog_write is a mess that takes a lot of effort to understand. It is
> a mass of nested loops with 4 space indents to get it to fit in 80 columns
> and lots of funky variables that aren't obvious what they mean or do.
> 
> Break it down into understandable chunks, format them properly and propagate
> the new log vector structure into it to support chaining of log vectors.

This looks good to me, but I have a bit of a hard time to verify it.

As mention before I think this would be much better off as one
patch to split up xlog_write to go in before patch 8, and a separate
one to deal with the xfs_log_vecs, which could in fact be merged into
the existing patch 8, just to be reordered to be last - or even first
of the actual delayed logging series.

<Prev in Thread] Current Thread [Next in Thread>