xfs
[Top] [All Lists]

Re: [PATCH 8/9] xfs: introduce new internal log vector structure

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 8/9] xfs: introduce new internal log vector structure
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Sat, 6 Mar 2010 06:31:19 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1267840284-4652-9-git-send-email-david@xxxxxxxxxxxxx>
References: <1267840284-4652-1-git-send-email-david@xxxxxxxxxxxxx> <1267840284-4652-9-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.19 (2009-01-05)
On Sat, Mar 06, 2010 at 12:51:23PM +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> The current log IO vector structure is a flat array and not
> extensible. To make it possible to keep separate log IO vectors for
> individual log items, we need a method of chaining log IO vectors
> together.
> 
> Introduce a new log vector type that can be used to wrap the
> existing log IO vectors on use that internally to the log. This
> means that the existing external interface (xfs_log_write) does not
> change and hence no changes to the transaction commit code are
> required.
> 
> This initial use of the new log vectors does not use the chaining
> capability of the new log vector structure - it is not needed to
> implement the flat vector array the current transaction commit path
> creates.

Given that we don't need it yet I wonder if it would be a better idea
to postponed it to the start of the actual delayed logging series?

patch 9 would be nice to have before, but that might be a bit too much
rebase work.  Anyway, looking into a real review soon.

<Prev in Thread] Current Thread [Next in Thread>