[Top] [All Lists]

Re: [PATCH 3/9] xfs: remove stale parameter from ->iop_unpin method

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 3/9] xfs: remove stale parameter from ->iop_unpin method
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Sat, 6 Mar 2010 05:55:53 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1267840284-4652-4-git-send-email-david@xxxxxxxxxxxxx>
References: <1267840284-4652-1-git-send-email-david@xxxxxxxxxxxxx> <1267840284-4652-4-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.19 (2009-01-05)
On Sat, Mar 06, 2010 at 12:51:18PM +1100, Dave Chinner wrote:
> The staleness of a object being unpinned can be directly derived
> from the object itself - there is no need to extract it from the
> object then pass it as a parameter into IOP_UNPIN().

Not quite as obvious as the description makes it sounds, as
we're removing the XFS_LID_BUF_STALE flag, and the buf item
which was the only place actually checking it is now switched
to the XFS_BLI_STALE flag in the xfs_buf_log_item, but as
these are set and cleared in exactly the same places it's fine
and a great cleanups.

Signed-off-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>