xfs
[Top] [All Lists]

Re: [PATCH 4/9] xfs: fix reservation release commit flag in xfs_bmap_add

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 4/9] xfs: fix reservation release commit flag in xfs_bmap_add_attrfork()
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Sat, 6 Mar 2010 05:52:07 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1267840284-4652-5-git-send-email-david@xxxxxxxxxxxxx>
References: <1267840284-4652-1-git-send-email-david@xxxxxxxxxxxxx> <1267840284-4652-5-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.19 (2009-01-05)
On Sat, Mar 06, 2010 at 12:51:19PM +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> xfs_bmap_add_attrfork() passes XFS_TRANS_PERM_LOG_RES to xfs_trans_commit()
> to indicate that the commit should release the permanent log reservation
> as part of the commit. This is wrong - the correct flag is
> XFS_TRANS_RELEASE_LOG_RES - and it is only by the chance that both these
> flags have the value of 0x4 that the code is doing the right thing.
> 
> Fix it by changing to use the correct flag.
> 
> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>

Looks good,


Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>