xfs
[Top] [All Lists]

Re: [PATCH v2] xfsqa: define resblks for tests near ENOSPC

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH v2] xfsqa: define resblks for tests near ENOSPC
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Fri, 5 Mar 2010 04:21:36 -0500
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <20100305020333.GN14317@xxxxxxxxxxxxxxxx>
References: <1267667254-7971-1-git-send-email-david@xxxxxxxxxxxxx> <20100304135623.GB31753@xxxxxxxxxxxxx> <20100304220421.GJ14317@xxxxxxxxxxxxxxxx> <20100305020333.GN14317@xxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.19 (2009-01-05)
On Fri, Mar 05, 2010 at 01:03:33PM +1100, Dave Chinner wrote:
> 
> Several tests assume a certain amount of disk space free after the
> reserve block pool is filled. Changing the default size of the
> reserve block pool breaks these tests because there is less space
> available that first thought.
> 
> Change these tests to specify a known reserve block pool size of
> 1024 blocks to ensure that they continue to work correctly even if
> the default size changes.

Looks good,


Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>