xfs
[Top] [All Lists]

Re: [PATCH 1/3] xfsqa: add delayed allocation @ ENOSPC exerciser

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 1/3] xfsqa: add delayed allocation @ ENOSPC exerciser
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Thu, 4 Mar 2010 02:57:53 -0500
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <20100303223122.GA14317@xxxxxxxxxxxxxxxx>
References: <1267597162-12092-1-git-send-email-david@xxxxxxxxxxxxx> <1267597162-12092-2-git-send-email-david@xxxxxxxxxxxxx> <20100303125619.GA26672@xxxxxxxxxxxxx> <20100303223122.GA14317@xxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.19 (2009-01-05)
On Thu, Mar 04, 2010 at 09:31:22AM +1100, Dave Chinner wrote:
> On Wed, Mar 03, 2010 at 07:56:19AM -0500, Christoph Hellwig wrote:
> > On Wed, Mar 03, 2010 at 05:19:20PM +1100, Dave Chinner wrote:
> > > + killall -9 dd > /dev/null 2>&1
> > 
> > This seems a bit dangerous.  I have at least one old system that
> > uses dd to continously read the kernel message buffer in the
> > background, and there's tons of other potential dd uses.
> 
> I only put it there to make sure they all died when I ^C'd out of a
> test run while testing the test. I forgot to remove it - I'll drop
> it from the patch.

Ok with that change.  Although beeing able to Ctrl+C testcase is a nice
gimmick to have.

<Prev in Thread] Current Thread [Next in Thread>