xfs
[Top] [All Lists]

Re: [PATCH 3/3] xfsqa: Add fiemap exerciser

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 3/3] xfsqa: Add fiemap exerciser
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Wed, 3 Mar 2010 07:58:39 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1267597162-12092-4-git-send-email-david@xxxxxxxxxxxxx>
References: <1267597162-12092-1-git-send-email-david@xxxxxxxxxxxxx> <1267597162-12092-4-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.19 (2009-01-05)
On Wed, Mar 03, 2010 at 05:19:22PM +1100, Dave Chinner wrote:
> From: Eric Sandeen <sandeen@xxxxxxxxxx>
> 
> Preliminary fiemap testing support based on a test util written by
> Josef Bacik.
> 
> For now it's only run with preallocation disabled, because xfs has a
> tendency to fill in holes with data blocks (EOF prealloc stuff I
> think) and similar for explicit preallocation, so this is breaking
> the preallocation tests for now, when it finds a "data" block where
> it expects a preallocated block.
> 
> Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>
> Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>

Looks good,


Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>