xfs
[Top] [All Lists]

Re: [PATCH 2/3] xfsqa: fix size specification for scratch mkfs

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 2/3] xfsqa: fix size specification for scratch mkfs
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Wed, 3 Mar 2010 07:58:09 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1267597162-12092-3-git-send-email-david@xxxxxxxxxxxxx>
References: <1267597162-12092-1-git-send-email-david@xxxxxxxxxxxxx> <1267597162-12092-3-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.19 (2009-01-05)
On Wed, Mar 03, 2010 at 05:19:21PM +1100, Dave Chinner wrote:
> When making a specifically sized scratch filesystem, we need to
> calculate the size rather than assigning the caclculation expression
> to a variable and passing that into the _scratch_mkfs_sized
> function. Currently sized filesystems are failing to be made and the
> code is falling back to full sized filesystems so we are not testing
> enospc issues correctly.

This seems rather fragile.  Maybe instead of calculating the bignums
which I suspect are the problem could we pass symbolic values like 104M
in and parse them in _scratch_mkfs_sized?

<Prev in Thread] Current Thread [Next in Thread>