xfs
[Top] [All Lists]

Re: [PATCH 2/2] xfs: remove xfs_ipin/xfs_iunpin

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 2/2] xfs: remove xfs_ipin/xfs_iunpin
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Fri, 19 Feb 2010 08:04:26 +1100
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20100218124322.GB6016@xxxxxxxxxxxxx>
References: <20100217194407.GB28758@xxxxxxxxxxxxx> <20100217230033.GW28392@xxxxxxxxxxxxxxxx> <20100218124322.GB6016@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.18 (2008-05-17)
On Thu, Feb 18, 2010 at 07:43:22AM -0500, Christoph Hellwig wrote:
> On Thu, Feb 18, 2010 at 10:00:33AM +1100, Dave Chinner wrote:
> > > + ASSERT(atomic_read(&->i_pincount) > 0);
> > 
> > I don't think that compiles. ;)
> 
> It does in fact compile for non-debug builds, but here's an updated

Very true...

> version that also compiles in a debug build:
> 
> ---
> 
> From: Christoph Hellwig <hch@xxxxxx>
> Subject: [PATCH 2/2] xfs: remove xfs_ipin/xfs_iunpin
> 
> Inodes are only pinned/unpinned via the inode item methods, and lots of
> code relies on that fact.  So remove the separate xfs_ipin/xfs_iunpin
> helpers and merge them into their only callers.  This also fixes up
> various duplicate and/or incorrect comments.
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Reviewed-by: Dave Chinner <david@xxxxxxxxxxxxx>

-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>