xfs
[Top] [All Lists]

Re: [PATCH] xfs: Non-blocking inode locking in IO completion

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH] xfs: Non-blocking inode locking in IO completion
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Thu, 18 Feb 2010 07:35:13 -0500
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <20100217211312.GQ28392@xxxxxxxxxxxxxxxx>
References: <1266384989-28928-1-git-send-email-david@xxxxxxxxxxxxx> <20100217192938.GA14015@xxxxxxxxxxxxx> <20100217211312.GQ28392@xxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.19 (2009-01-05)
On Thu, Feb 18, 2010 at 08:13:12AM +1100, Dave Chinner wrote:
> > The patch looks good to me - while I hate introducing random delay()
> > calls I don't really see a way around this. 
> 
> I thought about using queue_delayed_work(), but then the change
> became much bigger and has other side effects like increasing the
> size of the ioend structure.

Yes, now that the normal work struct and the delayed work struct are
different it would be a pain, agreed.

<Prev in Thread] Current Thread [Next in Thread>