Re: [PATCH 1/2] xfs: cleanup xfs_iunpin_wait/xfs_iunpin

xfs

Re: [PATCH 1/2] xfs: cleanup xfs_iunpin_wait/xfs_iunpin_nowait

To:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject:	Re: [PATCH 1/2] xfs: cleanup xfs_iunpin_wait/xfs_iunpin_nowait
From:	Dave Chinner <david@xxxxxxxxxxxxx>
Date:	Thu, 18 Feb 2010 09:57:16 +1100
Cc:	xfs@xxxxxxxxxxx
In-reply-to:	<20100217194356.GA28758@xxxxxxxxxxxxx>
References:	<20100217194356.GA28758@xxxxxxxxxxxxx>
User-agent:	Mutt/1.5.18 (2008-05-17)

On Wed, Feb 17, 2010 at 02:43:56PM -0500, Christoph Hellwig wrote:
> Remove the inode item pointer and ili_last_lsn checks in __xfs_iunpin_wait
> as any pinned inode is guaranteed to have them valid.  After this the
> xfs_iunpin_nowait case is nothing more than a xfs_log_force_lsn, as we
> know that the caller has already checked the pincount.
> 
> Make xfs_iunpin_nowait the new low-level routine just doing the log force
> and rewrite xfs_iunpin_wait around it.
> 
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Nice cleanup.

Reviewed-by: Dave Chinner <david@xxxxxxxxxxxxx>

-- 
Dave Chinner
david@xxxxxxxxxxxxx

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH 1/2] xfs: cleanup xfs_iunpin_wait/xfs_iunpin_nowait, Christoph Hellwig Re: [PATCH 1/2] xfs: cleanup xfs_iunpin_wait/xfs_iunpin_nowait, Dave Chinner <=

Previous by Date:	Re: [PATCH] xfs: kill xfs_lrw.h, Dave Chinner
Next by Date:	Re: [PATCH] xfstests: mount xfs with a context when selinux is on, Dave Chinner
Previous by Thread:	[PATCH 1/2] xfs: cleanup xfs_iunpin_wait/xfs_iunpin_nowait, Christoph Hellwig
Next by Thread:	[PATCH 2/2] xfs: remove xfs_ipin/xfs_iunpin, Christoph Hellwig
Indexes:	[Date] [Thread] [Top] [All Lists]