xfs
[Top] [All Lists]

Re: [PATCH] xfs: factor common xfs_trans_bjoin code

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH] xfs: factor common xfs_trans_bjoin code
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Wed, 17 Feb 2010 16:12:36 +1100
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20100215233509.GC28817@xxxxxxxxxxxxx>
References: <20100215233509.GC28817@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.18 (2008-05-17)
On Mon, Feb 15, 2010 at 06:35:09PM -0500, Christoph Hellwig wrote:
> Most of xfs_trans_bjoin is duplicated in xfs_trans_get_buf, xfs_trans_getsb
> and xfs_trans_read_buf.  Add a new _xfs_trans_bjoin which can be called
> by all four functions.
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Looks good.

Reviewed-by: Dave Chinner <david@xxxxxxxxxxxxx>

-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>