xfs
[Top] [All Lists]

Re: [PATCH] xfs: stop passing opaque handles to xfs_log.c routines

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH] xfs: stop passing opaque handles to xfs_log.c routines
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Wed, 17 Feb 2010 15:42:27 +1100
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20100215233454.GB28817@xxxxxxxxxxxxx>
References: <20100215233454.GB28817@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.18 (2008-05-17)
On Mon, Feb 15, 2010 at 06:34:54PM -0500, Christoph Hellwig wrote:
> Currenly we pass opaque xfs_log_ticket_t handles instead of struct
> xlog_ticket pointers, and void pointers instead of struct xlog_in_core
> pointers to various log manager functions.  Instead pass properly
> typed pointers after adding forward declarations for them to
> xfs_log.h, and adjust the touched function prototypes to the standard
> XFS style while at it.
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

This is almost identical to a patch I've got in my stack ATM :)
Looks good.

Reviewed-by: Dave Chinner <david@xxxxxxxxxxxxx>

-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>