Re: [PATCH] xfs: fix xfs_fsblock

xfs

Re: [PATCH] xfs: fix xfs_fsblock_t tracing

To:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject:	Re: [PATCH] xfs: fix xfs_fsblock_t tracing
From:	Dave Chinner <david@xxxxxxxxxxxxx>
Date:	Wed, 17 Feb 2010 15:19:10 +1100
Cc:	xfs@xxxxxxxxxxx
In-reply-to:	<20100215220219.GA4890@xxxxxxxxxxxxx>
References:	<20100215220219.GA4890@xxxxxxxxxxxxx>
User-agent:	Mutt/1.5.18 (2008-05-17)

On Mon, Feb 15, 2010 at 05:02:19PM -0500, Christoph Hellwig wrote:
> Using a static buffer in xfs_fmtfsblock means we can corrupt traces if
> multiple CPUs hit this code path at the same.  Just remove xfs_fmtfsblock
> for now and print the block number purely numerical.  If we want the
> NULLFSBLOCK and NULLSTARTBLOCK formatting back the best way would be
> a decoding plugin in the trace-cmd userspace command.
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Reviewed-by: Dave Chinner <david@xxxxxxxxxxxxx>

-- 
Dave Chinner
david@xxxxxxxxxxxxx

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH] xfs: fix xfs_fsblock_t tracing, Christoph Hellwig Re: [PATCH] xfs: fix xfs_fsblock_t tracing, Dave Chinner <=

Previous by Date:	Re: [PATCH 4/4] [PATCH 4/4] xfs: implement optimized fdatasync, Dave Chinner
Next by Date:	Re: [PATCH] xfs: split xfs_bmap_btalloc, Dave Chinner
Previous by Thread:	[PATCH] xfs: fix xfs_fsblock_t tracing, Christoph Hellwig
Next by Thread:	[PATCH] xfs: split xfs_bmap_btalloc, Christoph Hellwig
Indexes:	[Date] [Thread] [Top] [All Lists]