xfs
[Top] [All Lists]

Re: [PATCH 2/2] xfs_export_operations.commit_metadata

To: Ben Myers <bpm@xxxxxxx>
Subject: Re: [PATCH 2/2] xfs_export_operations.commit_metadata
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Wed, 17 Feb 2010 11:29:43 +1100
Cc: bfields@xxxxxxxxxxxx, linux-nfs@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx
In-reply-to: <20100216210418.5694.48417.stgit@case>
References: <20100216210026.5694.14423.stgit@case> <20100216210418.5694.48417.stgit@case>
User-agent: Mutt/1.5.18 (2008-05-17)
On Tue, Feb 16, 2010 at 03:04:18PM -0600, Ben Myers wrote:
> This is the commit_metadata export operation for XFS.
> 
> - Takes one inode to be committed.
> 
> - Forces the log up to the lsn of the inode.
> 
> - Doesn't force the log if the inode doesn't have a pincount.
> 
> Signed-off-by: Ben Myers <bpm@xxxxxxx>
> ---
>  fs/xfs/linux-2.6/xfs_export.c |   24 ++++++++++++++++++++++++
>  1 files changed, 24 insertions(+), 0 deletions(-)
> 
> diff --git a/fs/xfs/linux-2.6/xfs_export.c b/fs/xfs/linux-2.6/xfs_export.c
> index 87b8cbd..47a8d1f 100644
> --- a/fs/xfs/linux-2.6/xfs_export.c
> +++ b/fs/xfs/linux-2.6/xfs_export.c
> @@ -29,6 +29,7 @@
>  #include "xfs_vnodeops.h"
>  #include "xfs_bmap_btree.h"
>  #include "xfs_inode.h"
> +#include "xfs_inode_item.h"
>  
>  /*
>   * Note that we only accept fileids which are long enough rather than allow
> @@ -215,9 +216,32 @@ xfs_fs_get_parent(
>       return d_obtain_alias(VFS_I(cip));
>  }
>  
> +STATIC int
> +xfs_fs_nfs_commit_metadata(
> +     struct inode            *inode)
> +{
> +     struct xfs_inode        *ip = XFS_I(inode);
> +     struct xfs_mount        *mp = ip->i_mount;
> +     xfs_lsn_t               force_lsn = NULLCOMMITLSN;
> +     int                     error = 0;
> +
> +     xfs_ilock(ip, XFS_ILOCK_SHARED);
> +     if (xfs_ipincount(ip)) {
> +             force_lsn = ip->i_itemp->ili_last_lsn;
> +     }
> +     if (force_lsn != NULLCOMMITLSN) {
> +             error = _xfs_log_force(mp, force_lsn,
> +                             XFS_LOG_FORCE | XFS_LOG_SYNC, NULL);
> +     }

That could be simplified to:

        if (xfs_ipincount(ip))
                _xfs_log_force(mp, ip->i_itemp->ili_last_lsn
                                XFS_LOG_FORCE | XFS_LOG_SYNC, NULL);

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>