xfs
[Top] [All Lists]

Re: [PATCH V2] xfstests: fix up fs_perms test used by 126

To: Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject: Re: [PATCH V2] xfstests: fix up fs_perms test used by 126
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Tue, 9 Feb 2010 12:53:05 -0500
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, Theodore Tso <tytso@xxxxxxx>, xfs-oss <xfs@xxxxxxxxxxx>
In-reply-to: <4B71935E.7090907@xxxxxxxxxxx>
References: <4B6C4E81.6060201@xxxxxxxxxxx> <20100208194058.GC9527@xxxxxxxxxxxxx> <4B71935E.7090907@xxxxxxxxxxx>
User-agent: Mutt/1.5.19 (2009-01-05)
On Tue, Feb 09, 2010 at 10:54:54AM -0600, Eric Sandeen wrote:
> Test 126 was failing intermittently for Ted & I; it seems that
> this is because we were passing an unterminated string to
> fopen for the mode; I'm not certain why this made it fail,
> but it's pretty clearly not a good thing to do, and fixing
> it fixes the test.
> 
> Rather than passing around characters, do things string-wise,
> since that is what is ultimately used in fopen().
> 
> Reported-by: Theodore Tso <tytso@xxxxxxx>
> Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxxx>

Looks good,


Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>