xfs
[Top] [All Lists]

Re: make install in the brave new build system world

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: make install in the brave new build system world
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Mon, 8 Feb 2010 05:29:42 -0500
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <20100205114856.GE11483@xxxxxxxxxxxxxxxx>
References: <20100205092229.GA32454@xxxxxxxxxxxxx> <20100205104414.GC11483@xxxxxxxxxxxxxxxx> <20100205112850.GB28701@xxxxxxxxxxxxx> <20100205114856.GE11483@xxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.19 (2009-01-05)
On Fri, Feb 05, 2010 at 10:48:56PM +1100, Dave Chinner wrote:
> Ah, there's a double depenency chain.
> 
> The top level make file has:
> 
> install: default
> 
> Which causes "make install" to run the top level default target,
> which runs the default target in all the target subdirs.
> 
> Then, in each subdir, the makefile has:
> 
> install: default
> 
> Which when then install target is actually run, does another
> dependency check because it's got a local dependency on the depend
> target via the default target.
> 
> Replace the previous patch with the one below and try again.
> Now the "make install" will rebuild targets out of the local
> dependencies rather than a separate run of the top level default
> target (i.e. only traverse directories once).

Thanks, this looks much better.  We still don't implement the
quite behaviour for most install targets, but that should be relatively
simple to fix.  Maybe we can even replace all those handcode install
rules with generic one - I'll look into that once I get a bit time.

So

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

for this patch for now.


<Prev in Thread] Current Thread [Next in Thread>