xfs
[Top] [All Lists]

Re: make install in the brave new build system world

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: make install in the brave new build system world
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Fri, 5 Feb 2010 22:17:41 +1100
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20100205104414.GC11483@xxxxxxxxxxxxxxxx>
References: <20100205092229.GA32454@xxxxxxxxxxxxx> <20100205104414.GC11483@xxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.18 (2008-05-17)
On Fri, Feb 05, 2010 at 09:44:14PM +1100, Dave Chinner wrote:
> On Fri, Feb 05, 2010 at 04:22:29AM -0500, Christoph Hellwig wrote:
> > When doing make install in xfsprogs I get a lot of spew like this:
....
> >  b) for some reason the new silent make rules don't apply to this.
> 
> That's something I can't answer off the top of my head. I'll have a
> look into it.

Try the patch below.

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

xfsprogs: clean up make install build

The install targets did not get the silent treatment like the
normal build targets. Shut them up.

Signed-off-by: Dave Chinner <david@xxxxxxxxxxxxx>
---
 Makefile           |    9 ++++++---
 include/buildrules |    4 ----
 2 files changed, 6 insertions(+), 7 deletions(-)

diff --git a/Makefile b/Makefile
index 62c4258..31be846 100644
--- a/Makefile
+++ b/Makefile
@@ -107,13 +107,16 @@ install-dev: default $(addsuffix -install-dev,$(SUBDIRS))
 install-qa: install $(addsuffix -install-qa,$(SUBDIRS))
 
 %-install:
-       $(MAKE) -C $* install
+       @echo "Installing $@"
+       $(Q)$(MAKE) $(MAKEOPTS) -C $* install
 
 %-install-dev:
-       $(MAKE) -C $* install-dev
+       @echo "Installing $@"
+       $(Q)$(MAKE) $(MAKEOPTS) -C $* install-dev
 
 %-install-qa:
-       $(MAKE) -C $* install-qa
+       @echo "Installing $@"
+       $(Q)$(MAKE) $(MAKEOPTS) -C $* install-qa
 
 distclean: clean
        $(Q)rm -f $(DISTDIRT)
diff --git a/include/buildrules b/include/buildrules
index 1695e23..beb469b 100644
--- a/include/buildrules
+++ b/include/buildrules
@@ -101,7 +101,3 @@ ltdepend: $(CFILES) $(HFILES)
 depend: $(CFILES) $(HFILES)
        @echo "    [DEP]"
        $(Q)$(MAKEDEP) $(CFILES) > .dep
-
-
-#      $(Q)$(MAKEDEP) $(CFILES) | $(SED) -e 's,^\([^:]*\)\.o,\1,' > .dep
-

<Prev in Thread] Current Thread [Next in Thread>