xfs
[Top] [All Lists]

Re: [PATCH V2] mkfs: don't try to detect filesystems on regular files vi

To: Eric Sandeen <sandeen@xxxxxxxxxx>
Subject: Re: [PATCH V2] mkfs: don't try to detect filesystems on regular files via blkid
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Thu, 04 Feb 2010 13:43:25 -0600
Cc: Jim Meyering <meyering@xxxxxxxxxx>, xfs mailing list <xfs@xxxxxxxxxxx>
In-reply-to: <4B6B087F.80901@xxxxxxxxxxx>
References: <4B6AF6FC.6030101@xxxxxxxxxx> <4B6B087F.80901@xxxxxxxxxxx>
User-agent: Thunderbird 2.0.0.21 (X11/20090320)
Eric Sandeen wrote:
> from RH bug 
> https://bugzilla.redhat.com/show_bug.cgi?id=561870
> 
> # dd if=/dev/zero of=k bs=1MB count=2 seek=20; mkfs.xfs k 
> # mkfs.xfs: probe of k failed, cannot detect existing filesystem.
> # mkfs.xfs: Use the -f option to force overwrite.
> 
> blkid fails to do a probe of a regular file.
> 
> I wish blkid would cope with this, but for now it might
> be better to just turn it off.
> 
> I kept the size==0 check just in case we stumble on a 0-sized
> device, blkid doesn't like that either...
> 
> Reported-by: Jim Meyering <meyering@xxxxxxxxxx>
> Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>
> ---

OK NAK on that, hch has a better patch, we were driving blkid wrong.

-Eric

<Prev in Thread] Current Thread [Next in Thread>