Re: [PATCH V2] mkfs: don't try to detect filesystems on regular files via blkid

[Eric Sandeen <sandeen@xxxxxxxxxxx>]

Eric Sandeen wrote:
> from RH bug 
> https://bugzilla.redhat.com/show_bug.cgi?id=561870
> 
> # dd if=/dev/zero of=k bs=1MB count=2 seek=20; mkfs.xfs k 
> # mkfs.xfs: probe of k failed, cannot detect existing filesystem.
> # mkfs.xfs: Use the -f option to force overwrite.
> 
> blkid fails to do a probe of a regular file.
> 
> I wish blkid would cope with this, but for now it might
> be better to just turn it off.
> 
> I kept the size==0 check just in case we stumble on a 0-sized
> device, blkid doesn't like that either...
> 
> Reported-by: Jim Meyering <meyering@xxxxxxxxxx>
> Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>
> ---

OK NAK on that, hch has a better patch, we were driving blkid wrong.

-Eric