xfs
[Top] [All Lists]

Re: [PATCH 08/10] xfs: move the inode locking outside xfs_fsync()

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 08/10] xfs: move the inode locking outside xfs_fsync()
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Thu, 4 Feb 2010 11:07:52 -0500
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <20100203230833.GC5332@xxxxxxxxxxxxxxxx>
References: <1265153104-29680-1-git-send-email-david@xxxxxxxxxxxxx> <1265153104-29680-9-git-send-email-david@xxxxxxxxxxxxx> <20100203112917.GB19996@xxxxxxxxxxxxx> <20100203230833.GC5332@xxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.19 (2009-01-05)
On Thu, Feb 04, 2010 at 10:08:33AM +1100, Dave Chinner wrote:
> On Wed, Feb 03, 2010 at 06:29:17AM -0500, Christoph Hellwig wrote:
> > On Wed, Feb 03, 2010 at 10:25:02AM +1100, Dave Chinner wrote:
> > > We have a need for a delayed write inode flush operation
> > > to be made atomically with an fsync to avoid physically
> > > writing inodes but still keeping inode buffer information
> > > up to date for bulkstat.
> > > 
> > > Move the inode locking outside xfs_fsync() to allow this to
> > > be done.
> > 
> > What's the point of the lock_flags argument?  It should always
> > be IOLOCK_SHARED, so instead of passing it in as an argument
> > I'd rather add an assert to enforce it.
> 
> Fair enough. Updated patch below.
> 
> Cheers,
> 
> Dave.
> -- 
> Dave Chinner
> david@xxxxxxxxxxxxx
> 
> xfs: move the inode locking outside xfs_fsync() V2
> 
> We have a need for a delayed write inode flush operation
> to be made atomically with an fsync to avoid physically
> writing inodes but still keeping inode buffer information
> up to date for bulkstat.
> 
> Move the inode locking outside xfs_fsync() to allow this to
> be done.
> 
> Version 2
> - kill the lock_flags argument and simply assert XFS_IOLOCK_SHARED
>   in xfs_fsync().

Looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>