[Top] [All Lists]

Re: [PATCH 09/10] xfs: xfs_fs_write_inode() can fail to write inodes syn

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 09/10] xfs: xfs_fs_write_inode() can fail to write inodes synchronously V2
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Wed, 3 Feb 2010 15:56:48 -0500
Cc: bpm@xxxxxxx, xfs@xxxxxxxxxxx
In-reply-to: <20100203112753.GA19996@xxxxxxxxxxxxx>
References: <1265153104-29680-1-git-send-email-david@xxxxxxxxxxxxx> <1265153104-29680-10-git-send-email-david@xxxxxxxxxxxxx> <20100203112753.GA19996@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.19 (2009-01-05)
On Wed, Feb 03, 2010 at 06:27:53AM -0500, Christoph Hellwig wrote:
> Still not entirely happy with this one.  The first one is that I think
> the barriers in fsync are still too heavy for the normal sync use
> case.  I'd be more happy with exporting the body of xfs_fsync without
> the cache flushes (and a ebtter name than xfs_fsync) and use that
> for write_inode.
> That leaves open the NFSD case thought.  I'd prefer to have that fixed
> if possibly.  Ben, any chance you could send your patch to use fsync
> to the nfs list ASAP?  I think we'd be even better off to just force
> -o wsync and disable ->write_inode entirely for NFS, any chance you
> could test such a patch on your setup?

Thinking about it, we usually do cause a log buffer write from ->fsync
which means we submit the barrier anyway.  That might be the reason
why you're not seeing the performance hit in your testing.  With that
I'm okay with the patch as-is for now, we can micro-optimize it later.

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>