Re: [PATCH 08/10] xfs: move the inode locking outside xfs_fsync()

[Christoph Hellwig <hch@xxxxxxxxxxxxx>]

On Wed, Feb 03, 2010 at 10:25:02AM +1100, Dave Chinner wrote:
> We have a need for a delayed write inode flush operation
> to be made atomically with an fsync to avoid physically
> writing inodes but still keeping inode buffer information
> up to date for bulkstat.
> 
> Move the inode locking outside xfs_fsync() to allow this to
> be done.

What's the point of the lock_flags argument?  It should always
be IOLOCK_SHARED, so instead of passing it in as an argument
I'd rather add an assert to enforce it.

For more comments on if this is the right functionality to use
in write_inode see my comment to the next patch.