xfs
[Top] [All Lists]

Re: [PATCH 08/10] xfs: move the inode locking outside xfs_fsync()

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 08/10] xfs: move the inode locking outside xfs_fsync()
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Wed, 3 Feb 2010 06:29:17 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1265153104-29680-9-git-send-email-david@xxxxxxxxxxxxx>
References: <1265153104-29680-1-git-send-email-david@xxxxxxxxxxxxx> <1265153104-29680-9-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.19 (2009-01-05)
On Wed, Feb 03, 2010 at 10:25:02AM +1100, Dave Chinner wrote:
> We have a need for a delayed write inode flush operation
> to be made atomically with an fsync to avoid physically
> writing inodes but still keeping inode buffer information
> up to date for bulkstat.
> 
> Move the inode locking outside xfs_fsync() to allow this to
> be done.

What's the point of the lock_flags argument?  It should always
be IOLOCK_SHARED, so instead of passing it in as an argument
I'd rather add an assert to enforce it.

For more comments on if this is the right functionality to use
in write_inode see my comment to the next patch.

<Prev in Thread] Current Thread [Next in Thread>