| To: | Dave Chinner <david@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 09/10] xfs: xfs_fs_write_inode() can fail to write inodes synchronously V2 |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Wed, 3 Feb 2010 06:27:53 -0500 |
| Cc: | bpm@xxxxxxx, xfs@xxxxxxxxxxx |
| In-reply-to: | <1265153104-29680-10-git-send-email-david@xxxxxxxxxxxxx> |
| References: | <1265153104-29680-1-git-send-email-david@xxxxxxxxxxxxx> <1265153104-29680-10-git-send-email-david@xxxxxxxxxxxxx> |
| User-agent: | Mutt/1.5.19 (2009-01-05) |
Still not entirely happy with this one. The first one is that I think the barriers in fsync are still too heavy for the normal sync use case. I'd be more happy with exporting the body of xfs_fsync without the cache flushes (and a ebtter name than xfs_fsync) and use that for write_inode. That leaves open the NFSD case thought. I'd prefer to have that fixed if possibly. Ben, any chance you could send your patch to use fsync to the nfs list ASAP? I think we'd be even better off to just force -o wsync and disable ->write_inode entirely for NFS, any chance you could test such a patch on your setup? Besides that the patch is missing the comment from the previous iteration why we're still doing the delwri iflush for the sync == 1 case. I think keeping that one is important to explain the really weird reason for it. |
| Previous by Date: | Re: [PATCH 10/10] xfs: kill xfs_bawrite, Christoph Hellwig |
|---|---|
| Next by Date: | Re: [PATCH 08/10] xfs: move the inode locking outside xfs_fsync(), Christoph Hellwig |
| Previous by Thread: | [PATCH 09/10] xfs: xfs_fs_write_inode() can fail to write inodes synchronously V2, Dave Chinner |
| Next by Thread: | Re: [PATCH 09/10] xfs: xfs_fs_write_inode() can fail to write inodes synchronously V2, bpm |
| Indexes: | [Date] [Thread] [Top] [All Lists] |