xfs
[Top] [All Lists]

Re: [PATCH 06/10] xfs: kill the unused XFS_QMOPT_* flush flags V2

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 06/10] xfs: kill the unused XFS_QMOPT_* flush flags V2
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Wed, 3 Feb 2010 06:17:55 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1265153104-29680-7-git-send-email-david@xxxxxxxxxxxxx>
References: <1265153104-29680-1-git-send-email-david@xxxxxxxxxxxxx> <1265153104-29680-7-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.19 (2009-01-05)
On Wed, Feb 03, 2010 at 10:25:00AM +1100, Dave Chinner wrote:
> dquots are never flushed asynchronously. Remove the flag and the
> async write support from the flush function. Make the default flush
> a delwri flush to make the inode flush code, which leaves the
> XFS_QMOPT_SYNC the only flag remaining.  Convert that to use
> SYNC_WAIT instead, just like the inode flush code.
> 
> V2:
> - just pass flush flags straight through

Still looks good with that minor change,


Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>