| To: | xfs-oss <xfs@xxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH V2] xfstests: routine to create scratch of certain size |
| From: | Eric Sandeen <sandeen@xxxxxxxxxxx> |
| Date: | Tue, 02 Feb 2010 20:49:23 -0600 |
| In-reply-to: | <4B68D75A.9020105@xxxxxxxxxxx> |
| References: | <4B621D89.8070800@xxxxxxxxxxx> <4B68D75A.9020105@xxxxxxxxxxx> |
| User-agent: | Thunderbird 2.0.0.23 (Macintosh/20090812) |
Eric Sandeen wrote: > This is needed for later enospc tests to be generic > > Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxxx> > --- > > V2: Address Christoph's comment about use of MKFS_OPTIONS; > just do it like the other geom helper and explicitly -set- > MKFS_OPTIONS for scratch, to set the size, then just call > _scratch_mkfs > > (this would override any global MKFS_OPTIONS setting, but > I think that's ok for now, and not sure how these options might > interact w/ previously set MKFS_OPTIONS anyway) Scratch that, I'm not being diligent enough and didn't test this :/ (yay for "simple" changes) mke2fs takes the size arg at the end, after the device, so we cannot just set up MKFS_OPTIONS Sorry for the noise. -Eric (who will try to be more dilient now...) |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: State of XFS on ARM, Daniel Goller |
|---|---|
| Next by Date: | Re: [PATCH for-2.6.33] xfs: flush all log buffers in xlog_dealloc_log, Christoph Hellwig |
| Previous by Thread: | [PATCH V2] xfstests: routine to create scratch of certain size, Eric Sandeen |
| Next by Thread: | [PATCH 0/10] Delayed write metadata writeback V4, Dave Chinner |
| Indexes: | [Date] [Thread] [Top] [All Lists] |