[Top] [All Lists]

[patch 0/7] per-bdi flushing model improvements. reiser4

To: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, ReiserFS Development List <reiserfs-devel@xxxxxxxxxxxxxxx>
Subject: [patch 0/7] per-bdi flushing model improvements. reiser4
From: Edward Shishkin <edward.shishkin@xxxxxxxxx>
Date: Tue, 2 Feb 2010 02:55:46 +0100
Cc: linux-fsdevel@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx, jens.axboe@xxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:from:to:subject:date :user-agent:mime-version:message-id:cc:content-type :content-transfer-encoding; bh=WvTl84i6AssHSnJeG9IiC9Zb7FQlV2PJhaSSdLfavFg=; b=Um3YKDDQTTWMuGEmfb67eythFwLQWZ0KlSzhyZIrfQDeMU2uDKA72a6jP46I9NQEG6 IUnoDzyfybpFiUyG4eWwN+wD/PDpKgg45iXMQhauHwbPIQKd5Vah54oZx6t9fxj72rz1 GtJ6+4Q4voGb8q6FKbGM2YgCCPJR7T3Pc59y0=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:subject:date:user-agent:mime-version:message-id:cc :content-type:content-transfer-encoding; b=VxM+xISKAEtQZgcWfOOCu4cjm2RkcfHcGd5vSK9jQiQmMnrX3fTiAqhlNkVPcwItZ3 /qQFmSX72GX+jWK2hlrzkRZP2/4FXhokCbZmAs8Zw4kpu1Ir8js/dMVuAl7oPFSy/Ca7 m+tvWQpcjB1ytwx58z9Cp1DYSDhxkvXOYpBhw=
User-agent: KMail/1.12.3 (Linux/; KDE/4.3.3; i686; ; )

Andrew Morton wrote:
> reiser4 is currently disabled in -mm (via reiser4-disable.patch)
> because recent changes to fs/fs/writeback.c wrecked the build.  I fixed
> it about ten times as the underlying code was churning, then gave up.  It
> would be nice if you take a look at that sometime please.

I have taken a look at fs/fs-writeback.c and found that per-superblock
flushing interface is eliminated. However migrating to per-bdi flushing
model doesn't necessarily means that such interface doesn't exist or is
not needed anymore. Flushing in accordance with the scheme "data-inode-
data-inode-..." would be very suboptimal for reiser4. Also xfs people
were unhappy with such flushing model:

Moreover, current stuff doesn't look fine. Why do we pin/unpin
superblock for every inode? It would be more reasonable to pin it for the
whole group of inodes and call a flushing handler for them. The patch 4
introduces such handler writeback_sb_inodes (which resembles dropped
sync_sb_inodes, the difference is that the newer version doesn't flush
necessarily all inodes of the superblock). Please, consider pushing this
patch to mainline.

The patch 5 adds a super operation .writeback_inodes (former .sync_inodes)
which allows a file system to make optimizations. It can happen that
reiser4 will flush a bit more inodes then generic implementation suggests.
"a bit more" doesn't mean "all dirty inodes of the superblock" (see a
comment about atoms in the header of patch 6).

Finally, some file systems have its own means for periodical writeout
of dirty data. Since b_io contains inodes of many superblocks we need
to evict our inodes back to dirty list when flushing is going on with
for_kupdate flag installed. The new library function
writeback_skip_sb_inodes() provides such possibility.

Please, apply.


<Prev in Thread] Current Thread [Next in Thread>