[Top] [All Lists]

Re: [PATCH] xfstests 224: test aio hole-fill at 4g

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH] xfstests 224: test aio hole-fill at 4g
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Sat, 30 Jan 2010 13:46:10 -0600
Cc: tytso@xxxxxxx, ext4 development <linux-ext4@xxxxxxxxxxxxxxx>, xfs-oss <xfs@xxxxxxxxxxx>, Giel de Nijs <giel@xxxxxxxxxxxxxx>
In-reply-to: <20100130191113.GC10181@xxxxxxxxxxxxx>
References: <4B633F9A.8000404@xxxxxxxxxxx> <20100130105501.GA22909@xxxxxxxxxxxxx> <4B645B0D.205@xxxxxxxxxxx> <20100130172502.GA788@xxxxxxxxx> <4B647AFE.5000507@xxxxxxxxxxx> <20100130191113.GC10181@xxxxxxxxxxxxx>
User-agent: Thunderbird (Macintosh/20090812)
Christoph Hellwig wrote:
> On Sat, Jan 30, 2010 at 12:31:26PM -0600, Eric Sandeen wrote:
>> These are the deps that I know xfstests has, to build and to run:
>> BuildRequires:  autoconf, libtool, xfsprogs-devel, e2fsprogs-devel
>> BuildRequires:  libacl-devel, libattr-devel, libaio-devel
>> Requires:       bash, xfsprogs, xfsdump, perl, acl, attr, bind-utils
>> Requires:       bc, indent, quota
>> which isn't so bad...
> Doesn't seem to bad.  Indent is afaik only needed for the weird 122 test
> which doesn't apply to non-xfs filesystems.

and FWIW, we do:

_require_command /usr/bin/indent

so it'll just not run if it's not there (the above was for an rpm
attempt I made, wishing to automatically pull in everything that
might possibly be needed.)


>> I'm not sure an xfsprogs dependency is so onerous; plenty has depended
>> on e2fsprogs through the years and we've lived with that ;)  But
>> the lag time for xfsprogs to use released xfs_io functionality is a
>> bit of a bummer.
>> But I guess I don't have a great answer for who else uses xfs_io:
> I use xfs_io in lots various local scripts.  It's a really handly
> tool for exercising some of the more weird I/O related syscalls.

<Prev in Thread] Current Thread [Next in Thread>