xfs
[Top] [All Lists]

Re: [PATCH] xfstests: 223 - test file alignment on stripe geometry

To: Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject: Re: [PATCH] xfstests: 223 - test file alignment on stripe geometry
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Sat, 30 Jan 2010 14:09:35 -0500
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs-oss <xfs@xxxxxxxxxxx>, ext4 development <linux-ext4@xxxxxxxxxxxxxxx>
In-reply-to: <4B645AB9.8050508@xxxxxxxxxxx>
References: <4B621529.20708@xxxxxxxxxxx> <20100130105236.GA18286@xxxxxxxxxxxxx> <4B645AB9.8050508@xxxxxxxxxxx>
User-agent: Mutt/1.5.19 (2009-01-05)
> didn't break anything for me; I wanted to be able to see the mkfs
> results w/ geometry, is all.  Will re-double-check but it was fine AFAIK.

Yeah, doesn't seem to cause any problems with a full xfsqa run for me.

> > This is a bit misnamed as it's not a generic fibmap tool but rather
> > a specific tool comparing the bmap to the sunit alignment.
> > 
> 
> good point .. how about making it more generic, something like:
> 
> fibmap -o <file offset> -l <length> -s <stripe alignment> <filename>
> 
> hmm though I hate to reqwrite filefrag ... :)
> 
> I suppose something like this could go into xfs_io as well, but that
> makes this test unavailable to the masses until another release, at least.

I'd just leave it as is but call it t_stripealign or similar.

<Prev in Thread] Current Thread [Next in Thread>