xfs
[Top] [All Lists]

Re: [PATCH] xfstests: 223 - test file alignment on stripe geometry

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH] xfstests: 223 - test file alignment on stripe geometry
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Sat, 30 Jan 2010 10:13:45 -0600
Cc: xfs-oss <xfs@xxxxxxxxxxx>, ext4 development <linux-ext4@xxxxxxxxxxxxxxx>
In-reply-to: <20100130105236.GA18286@xxxxxxxxxxxxx>
References: <4B621529.20708@xxxxxxxxxxx> <20100130105236.GA18286@xxxxxxxxxxxxx>
User-agent: Thunderbird 2.0.0.23 (Macintosh/20090812)
Christoph Hellwig wrote:
>> +# real QA test starts here
>> +_supported_fs xfs ext4
> 
> I'd make this generic and just do the notrun in scratch_mkfs_geom for
> non-supported filesystems.

fair enough

>> +scratch_mkfs_geom()
>> +{
> 
> And I'd throw this one into common.rc.

ok

>> +=== Testing size 1073745920 falloc on 128k stripe ===
>> +SCRATCH_MNT/file-1073745920-falloc: well-aligned
>> diff --git a/common.rc b/common.rc
>> index 6424871..97513cc 100644
>> --- a/common.rc
>> +++ b/common.rc
>> @@ -292,7 +292,7 @@ _scratch_mkfs()
>>          $MKFS_UDF_PROG $MKFS_OPTIONS $* $SCRATCH_DEV > /dev/null
>>      ;;
>>      *)
>> -    /sbin/mkfs -t $FSTYP -- $MKFS_OPTIONS $* $SCRATCH_DEV > /dev/null
>> +    /sbin/mkfs -t $FSTYP -- $MKFS_OPTIONS $* $SCRATCH_DEV
> 
> Hmm, doesn't this change break other testcase?  Anyway needs some
> rationale in the changelog.

didn't break anything for me; I wanted to be able to see the mkfs
results w/ geometry, is all.  Will re-double-check but it was fine AFAIK.

>> index 0000000..fa005b2
>> --- /dev/null
>> +++ b/src/fibmap.c
> 
> This is a bit misnamed as it's not a generic fibmap tool but rather
> a specific tool comparing the bmap to the sunit alignment.
> 

good point .. how about making it more generic, something like:

fibmap -o <file offset> -l <length> -s <stripe alignment> <filename>

hmm though I hate to reqwrite filefrag ... :)

I suppose something like this could go into xfs_io as well, but that
makes this test unavailable to the masses until another release, at least.

-Eric

<Prev in Thread] Current Thread [Next in Thread>