xfs
[Top] [All Lists]

Re: [PATCH] xfstests: filter selinux output in _acl_ls

To: xfs-oss <xfs@xxxxxxxxxxx>
Subject: Re: [PATCH] xfstests: filter selinux output in _acl_ls
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Thu, 28 Jan 2010 17:34:36 -0600
In-reply-to: <4B61C1BC.4050800@xxxxxxxxxxx>
References: <4B61C1BC.4050800@xxxxxxxxxxx>
User-agent: Thunderbird 2.0.0.23 (Macintosh/20090812)
Eric Sandeen wrote:
> When selinux is on, ls -l gives us a "." to indicate selinux
> attrs, which breaks some tests:
> 
>  === Test minimal ACE ===
>  Setup file
> --rwxrw-r-- id1 id2 file1
> +-rwxrw-r--. id1 id2 file1
> 
> so filter that out.

Hmm NAK this one for now; there are more places that need this
fixup, maybe an _ls_l() would be a good idea and put the filter
in one spot.

-Eric

> Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxxx>
> ---
> 
> Index: xfstests/common.attr
> ===================================================================
> --- xfstests.orig/common.attr
> +++ xfstests/common.attr
> @@ -58,7 +58,10 @@ _acl_filter_id()
>  #
>  _acl_ls()
>  {
> -    ls -ln $* | awk '{ print $1, $3, $4, $NF }' | _acl_filter_id
> +    ls -ln $* |      \
> +    sed "s/\(.*\)\. /\1 /" | \
> +    awk '{ print $1, $3, $4, $NF }' | \
> +    _acl_filter_id
>  } 
>  
>  #
> 
> _______________________________________________
> xfs mailing list
> xfs@xxxxxxxxxxx
> http://oss.sgi.com/mailman/listinfo/xfs
> 

<Prev in Thread] Current Thread [Next in Thread>