xfs
[Top] [All Lists]

Re: [PATCH 2/2] xfstests: Automatic build dependency calculations

To: Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject: Re: [PATCH 2/2] xfstests: Automatic build dependency calculations
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Thu, 28 Jan 2010 09:57:37 +1100
Cc: xfs@xxxxxxxxxxx
In-reply-to: <4B60932D.7060709@xxxxxxxxxxx>
References: <1264053773-6054-1-git-send-email-david@xxxxxxxxxxxxx> <1264053773-6054-3-git-send-email-david@xxxxxxxxxxxxx> <4B60932D.7060709@xxxxxxxxxxx>
User-agent: Mutt/1.5.18 (2008-05-17)
On Wed, Jan 27, 2010 at 01:25:33PM -0600, Eric Sandeen wrote:
> Dave Chinner wrote:
> > Currently the xfstest builds do not have any automatic dependency
> > calculations. It relies on a separate make depend run to build or
> > update dependency information. It also relies on an external
> > makedepend binary. If that binary does not exist, the dependencies
> > do not get calculated.
> > 
> > To remove the dependency on makedepend, gcc can be used instead as
> > it has a command to generate dependency information. This patch
> > changes the dependency rule building to use gcc.
> > 
> > In case anyone uses an old (several years) gcc compiler or a
> > compiler that doesn't support gcc compatible dependency generation,
> > a new configure check is added to turn off dependency checking so
> > builds can still be done.
> > 
> > To use the dependencies automatically, we need to use a special
> > include makefile directive to include the build dependencies into
> > the current makefile.  Essentially once the dependencies are
> > calculated, they can be included into the makefile and make will
> > recalculate the build dependencies automatically based on that
> > information.
> > 
> > Hence we get a build that automatically calculates and keeps
> > dependencies up to date without dependence on any external tools.
> > 
> > Signed-off-by: Dave Chinner <david@xxxxxxxxxxxxx>
> 
> seems to be some fallout from this at least on my F10 box:
> 
> /usr/bin/makedepend: warning:  ignoring option -Wall
> /usr/bin/makedepend: error:  cannot open "no-strict-aliasing"
> 
> also this change:
> 
> -       preallo_rw_pattern_reader preallo_rw_pattern_writer ftrunc trunc \
> -       fs_perms testx looptest locktest unwritten_mmap \
> +       ftrunc trunc fs_perms testx looptest locktest unwritten_mmap \
>         bulkstat_unlink_test bulkstat_unlink_test_modified t_dir_offset \
> 
> ...
> 
> 
> +PREALLO_TARGETS = preallo_rw_pattern_reader
> 
> seems to have lost the build of preallo_rw_pattern_reader & writer.
> 
> Was that stray, or what were you going for there?

I thought I fixed all that up after hch's patches went in. Bugger.
I'll try to get a few minutes at lunchtime to fix it.

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>